Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Dictionary] Change filter to multiselect + Update TestPlan #7040

Merged
merged 1 commit into from
Jan 8, 2021
Merged

[Data Dictionary] Change filter to multiselect + Update TestPlan #7040

merged 1 commit into from
Jan 8, 2021

Conversation

jesscall
Copy link
Contributor

Brief summary of changes

This PR does the following:

Testing instructions (if applicable)

See TestPlan for instructions on testing the filters. Specifically steps 4 and 6.

4 - Check that selecting multiple instruments returns all relevant results.
...
6 - Ensure that 'Clear Filters' button works.

Link(s) to related issue(s)

@jesscall jesscall added this to the 24.0.0 milestone Sep 16, 2020
@jesscall jesscall linked an issue Sep 16, 2020 that may be closed by this pull request
[datadict] Clear filters #6965
Closed
@jesscall jesscall added the "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help label Sep 28, 2020
@jesscall
Copy link
Contributor Author

@kongtiaowang Do you have any insight on why travis is failing? Any help is appreciated!

@kongtiaowang kongtiaowang removed the "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help label Sep 30, 2020
@ridz1208 ridz1208 removed this from the 24.0.0 milestone Nov 27, 2020
@laemtl laemtl self-requested a review January 7, 2021 22:59
@laemtl laemtl added the Passed manual tests PR has been successfully tested by at least one peer label Jan 7, 2021
@driusan driusan merged commit b153c2e into aces:main Jan 8, 2021
@ridz1208 ridz1208 added this to the 24.0.0 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laemtl laemtl laemtl approved these changes

Assignees

@pierre-p-s pierre-p-s

Labels
Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Milestone
24.0.0
Development

Successfully merging this pull request may close these issues.

[datadict] Clear filters [datadict] Cannot select multiple instruments
6 participants
@jesscall @laemtl @driusan @kongtiaowang @ridz1208 @pierre-p-s